Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added image loading in SUNRGB-D dataset #195

Merged
merged 6 commits into from
Nov 25, 2020

Conversation

yezhen17
Copy link
Collaborator

@yezhen17 yezhen17 commented Nov 6, 2020

Also fixed a bug in sunrgbd_data_utils.py; created a testing imvotenet config file to test that the loading is correct

@codecov
Copy link

codecov bot commented Nov 6, 2020

Codecov Report

Merging #195 (d9292e2) into imvotenet (37ce187) will increase coverage by 0.05%.
The diff coverage is 75.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           imvotenet     #195      +/-   ##
=============================================
+ Coverage      49.58%   49.63%   +0.05%     
=============================================
  Files            165      165              
  Lines          11076    11100      +24     
  Branches        1691     1696       +5     
=============================================
+ Hits            5492     5510      +18     
- Misses          5258     5259       +1     
- Partials         326      331       +5     
Flag Coverage Δ
unittests 49.63% <75.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/models/detectors/__init__.py 100.00% <ø> (ø)
mmdet3d/models/detectors/votenet.py 33.33% <ø> (ø)
mmdet3d/datasets/sunrgbd_dataset.py 81.35% <75.00%> (-4.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37ce187...43b0b1f. Read the comment docs.

@yezhen17
Copy link
Collaborator Author

removed imvotenet relevant files

@filaPro
Copy link
Contributor

filaPro commented Nov 13, 2020

Hi @THU17cyz,

(May be not the best place for this question, but anyway) Do you have plans to finish ImVoteNet implemetation? Thank you.

@yezhen17
Copy link
Collaborator Author

yezhen17 commented Nov 18, 2020

Hi @THU17cyz,

(May be not the best place for this question, but anyway) Do you have plans to finish ImVoteNet implemetation? Thank you.

Yes, I'm working on reproducing ImVoteNet. But since I'm not working full-time, it may take some time.

Copy link
Member

@Tai-Wang Tai-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to modify according to current comments. No additional problem from my point of view.

@ZwwWayne ZwwWayne merged commit 3be0f68 into open-mmlab:imvotenet Nov 25, 2020
yezhen17 added a commit to yezhen17/mmdetection3d that referenced this pull request Dec 3, 2020
Added image loading in SUNRGB-D dataset (open-mmlab#195)
ZwwWayne added a commit that referenced this pull request Mar 24, 2021
* Added image loading in SUNRGB-D dataset (#195)

* image loading

* format and docstring fix

* removed irrelevant files

* removed irrelevant files

* load image only if modality is pc+img

* added modality like nuscenes

* Added imvotenet image branch pretrain (#217)

* image loading

* naive commit

* format and docstring fix

* removed irrelevant files

* removed irrelevant files

* load image only if modality is pc+img

* added modality like nuscenes

* pretrain_2d_model

* finetune sunrgbd

* finetune sunrgbd

* deleted unused code

* fixed a bug

* resolve conflict

* update config file

* fix docstring and configs

* integrated vote fusion

* coords transform and unit test

* Update docstring

* refactor and add unit test

* fix bug caused by mmcv upgrade; delete pdb breakpoint

* add point fusion unittest

* remove unused file

* fix typos

* updates

* add assertion info

* update

* add unittest

* add vote fusion unittest

* add vote fusion unittest

* [Refactor] VoteNet refactor (#322)

* votenet refactor

* remove file

* minor update

* docstring

* initial update of imvotenet

* [Feature] Support vote fusion (#297)

* integrated vote fusion

* coords transform and unit test

* Update docstring

* refactor and add unit test

* add point fusion unittest

* remove unused file

* updates

* add assertion info

* update

* add unittest

* add vote fusion unittest

* add vote fusion unittest

* minor update

* docstring

* change np ops to torch

* refactor test

* update

* refactor of image mlp and np random ops to torch

* add docstring

* add config and mod dataset

* fix bugs

* add_comments

* fix bugs

* fix_bug

* fix bug

* fix bug

* fix bug

* fix bug

* final fix

* fix bug

* ?

* add docstring

* move train/test cfg

* change img mlp default param

* rename config

* minor mod

* change config name

* move train/test cfg

* some fixes and 2d utils

* fix config name

* fix config override issue

* config simplify & reformat

* explicitly set eval mode->override train()

* add fix_img_branch to config

* remove set_img_branch_eval_mode

* temporal fix, change calibs to calib

* more docstring and view/reshape, expand/repeat change

* complete imvotenet docstring

* fix docstring

* add config and some minor fix

* rename config

Co-authored-by: ZwwWayne <wayne.zw@outlook.com>
tpoisonooo pushed a commit to tpoisonooo/mmdetection3d that referenced this pull request Sep 5, 2022
…untime. (open-mmlab#195)

* Add deform_conv_openvino.

* Add get_bboxes_of_vfnet_head.

* Fix vfnet and add test_get_bboxes_of_vfnet_head.

* Update docs.

* Fix test_shufflenetv2_backbone__forward for openvino.

* Fixes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants